Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document supermentor requirement for representation feedback #419

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Document supermentor requirement for representation feedback #419

merged 1 commit into from
Dec 6, 2022

Conversation

ErikSchierboom
Copy link
Member

No description provided.

@ErikSchierboom ErikSchierboom requested a review from iHiD December 6, 2022 08:49
ee7
ee7 reviewed Dec 6, 2022
View reviewed changes
Copy link
Member

@ee7 ee7 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe be explicit that the user must satisfy all of those conditions, not just any of them?

Edit: And is there some manual override, or a mechanism to provide representation feedback for a track that is not yet launched, or recently launched? Please remind me: does someone with write access to a track repo automatically have the permission to leave representation feedback for that track? If so, should we explain that here?

@ErikSchierboom
Copy link
Member Author

[...] is there some manual override, or a mechanism to provide representation feedback for a track that is not yet launched, or recently launched?

There is no manual override at the moment.

[...] does someone with write access to a track repo automatically have the permission to leave representation feedback for that track?

They don't.

@ErikSchierboom
Copy link
Member Author

Maybe be explicit that the user must satisfy all of those conditions, not just any of them?

Updated

@ErikSchierboom ErikSchierboom merged commit a02c599 into main Dec 6, 2022
@ErikSchierboom ErikSchierboom deleted the supermentor-docs branch December 6, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ee7 ee7 ee7 left review comments

@iHiD iHiD iHiD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ErikSchierboom @iHiD @ee7