Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document snippet extension #410

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Document snippet extension #410

merged 2 commits into from
Nov 16, 2022

Conversation

ErikSchierboom
Copy link
Member

No description provided.

@ErikSchierboom ErikSchierboom requested review from iHiD and ee7 November 15, 2022 15:43
ee7
ee7 approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@ee7 ee7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you also document approaches.snippet_extension in lint.md?

I guess there should be a linting rule like "must not begin with a dot"?

@ErikSchierboom
Copy link
Member Author

I guess there should be a linting rule like "must not begin with a dot"?

I think that I'll just ignore leading dots.

@ErikSchierboom ErikSchierboom merged commit 43a2d22 into main Nov 16, 2022
@ErikSchierboom ErikSchierboom deleted the snippet-extension branch November 16, 2022 07:29
ErikSchierboom added a commit to ErikSchierboom/docs that referenced this pull request Nov 22, 2022
@ErikSchierboom
Document snippet extension (exercism#410)
7786870 
Document snippet extension
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ee7 ee7 ee7 approved these changes

@iHiD iHiD Awaiting requested review from iHiD

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ErikSchierboom @ee7