Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document key for exercise files #407

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Document key for exercise files #407

merged 2 commits into from
Nov 15, 2022

Conversation

ErikSchierboom
Copy link
Member

No description provided.

Copy link
Member Author

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC @ee7

@@ -312,6 +312,8 @@ This file contains meta information on the exercise:
- `blurb`: A short description of this exercise. Its length must be <= 350. Markdown is _not_ supported (required)
- `source`: The source this exercise is based on (optional)
- `source_url`: The URL of the source this exercise is based on (optional)
- `representer`: Meta information related to how the representer processes this file (optional)
- `version`: An integer for the version of the representer to use for the exercise (required if parent key is present)
Copy link
Member Author

@ErikSchierboom ErikSchierboom Nov 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe:

An integer which can be incremented to invalidate representations (required if parent key is present - defaults to 1 downstream if missing, so set to 2 to initially invalidate).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Ah, here was the famous reply-via-overwriting-edit).

Parsing an omitted version property the same as an explicit "version": 1 sounds OK to me.

Note that configlet lint leaned towards not erroring for an empty optional key, though. So maybe "representer": {} shouldn't be an error. But perhaps removed with configlet fmt.

@ErikSchierboom ErikSchierboom requested a review from iHiD November 11, 2022 13:44
building/tracks/concept-exercises.md Outdated Show resolved Hide resolved
Co-authored-by: ee7 <45465154+ee7@users.noreply.github.com>
@ErikSchierboom ErikSchierboom merged commit 24881b8 into main Nov 15, 2022
@ErikSchierboom ErikSchierboom deleted the representer-version branch November 15, 2022 13:11
ErikSchierboom added a commit to ErikSchierboom/docs that referenced this pull request Nov 22, 2022
Document  key for exercise  iles

Co-authored-by: ee7 <45465154+ee7@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants