Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #404

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Fix typos #404

merged 1 commit into from
Nov 8, 2022

Conversation

kianmeng
Copy link
Contributor

@kianmeng kianmeng commented Nov 7, 2022

Found via codespell -L filetests,inout,nclude

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One tiny nit

@@ -102,7 +102,7 @@ We support special types of blocks that can be added to documents to pull out co
We support three types of blocks:

- **exercism/note:** Blocks that pull out some extra special information
- **exercism/caution:** Things that people should know about or tread carefully with
- **exercism/caution:** Things that people should know about or treat carefully with
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is not correct. One treads carefully, not treats carefully

Copy link
Member

@ee7 ee7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, conditional on making the change that Erik suggested.

Found via `codespell -L filetests,inout,nclude`
@kianmeng kianmeng requested review from ee7 and ErikSchierboom and removed request for ee7 and ErikSchierboom November 8, 2022 01:41
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ErikSchierboom ErikSchierboom added the x:rep/small Small amount of reputation label Nov 8, 2022
@ErikSchierboom ErikSchierboom merged commit 8df3241 into exercism:main Nov 8, 2022
@kianmeng
Copy link
Contributor Author

kianmeng commented Nov 9, 2022

🥳 🥳 🥳 🥳 🥳

ErikSchierboom pushed a commit to ErikSchierboom/docs that referenced this pull request Nov 22, 2022
Found via `codespell -L filetests,inout,nclude`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:rep/small Small amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants