Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the grammar of the concept-exercises.md #301

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

DJkal11
Copy link
Contributor

@DJkal11 DJkal11 commented Nov 6, 2021

No description provided.

building/tracks/concept-exercises.md Show resolved Hide resolved
- Test suite: verifies a solution's correctness (required)
- Stub implementation: provides a starting point for students (required)
- Exemplar implementation: provides an idiomatic implementation that passes all the tests (required)
- Additional files: ensures that the tests can run (optional)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bullet group may be appropriate to change, because we are speaking a little more individually perhaps. Except probably that last bullet, where additional files do ensure that the tests can run.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your feedback, will keep this in mind moving forward.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this PR? Would you revert the changes above and keep these? I would love to be able to get these in.

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the change suggested by @kotp and have suggested the change in a comment.

Could you also update the https://github.com/exercism/docs/blob/main/building/tracks/practice-exercises.md document? It has similar text.

building/tracks/concept-exercises.md Outdated Show resolved Hide resolved
@ErikSchierboom
Copy link
Member

@DJkal11 Small bump. See the above comments

@ErikSchierboom ErikSchierboom added the x:rep/small Small amount of reputation label Nov 22, 2022
@ErikSchierboom ErikSchierboom merged commit 985ab43 into exercism:main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:rep/small Small amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants