Remove duplicate linting rule #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a duplicate of a previous rule: - The `"exercises.concept[].concepts"` values must match the `"concepts.slug"` property of one of the concepts
ErikSchierboom
approved these changes
Sep 14, 2021
I don't think it should error, but I could definitely see it being a warning. |
|
Want me to merge or do you want to do something with my above comment? |
|
Please merge - let's follow-up later. I've opened #265 to track. Feel free to PR it yourself, if you want. We'll have to decide how to talk about "warnings", since there currently aren't any in the spec. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a duplicate of a previous rule:
Pinging @ErikSchierboom for review: This was a duplicate, right?
Is the intention that we also check the other way around? That is, should
configlet lintcomplain if aconcepts.slugvalue does not exist in anyexercises.concept[].conceptsarray?