Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for repeated columns on every page when printing. #799

Merged
merged 1 commit into from
May 7, 2019
Merged

Add support for repeated columns on every page when printing. #799

merged 1 commit into from
May 7, 2019

Conversation

FreakenK
Copy link
Contributor

No description provided.

@alubbe alubbe requested review from Siemienik and guyonroche May 3, 2019 04:53
@alubbe
Copy link
Member

alubbe commented May 3, 2019

PR and tests look good, but I have never used this feature of exceljs (or excel). Can someone review it who is more closely aware of how this is used?

guyonroche
guyonroche approved these changes May 7, 2019
View reviewed changes
Copy link
Collaborator

@guyonroche guyonroche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - will merge when I can

@guyonroche guyonroche merged commit a7bb3aa into exceljs:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guyonroche guyonroche guyonroche approved these changes

@Siemienik Siemienik Awaiting requested review from Siemienik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FreakenK @alubbe @guyonroche