Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the temp lib to tmp #775

Merged
merged 1 commit into from
Apr 4, 2019
Merged

Conversation

defshift
Copy link
Contributor

@defshift defshift commented Apr 3, 2019

Right we are using the temp package for creating temp files to cache shared strings in the workbook reader. The problem is that the temp uses a global cache to keep track of its files, which is not safe for concurrent operation. In particular, the cleanup of one task will delete all files tracked globally, incl. those still needed by another task. This results in a node error that a file was not found.

In this PR we replace the temp to tmp which is safe for concurrent operations.

@defshift defshift added the bug label Apr 3, 2019
Copy link
Member

@alubbe alubbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used this version in production since last December, no complaints

@defshift defshift merged commit 43ba7ec into master Apr 4, 2019
@defshift defshift deleted the feature/replace-lib-for-temp-files branch April 4, 2019 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants