Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all node_modules are compatible with IE11 #1193

Merged
merged 2 commits into from
Apr 7, 2020
Merged

Ensure all node_modules are compatible with IE11 #1193

merged 2 commits into from
Apr 7, 2020

Conversation

alubbe
Copy link
Member

@alubbe alubbe commented Apr 1, 2020

No description provided.

@alubbe alubbe requested review from guyonroche and Siemienik April 1, 2020 10:37
@alubbe
Copy link
Member Author

alubbe commented Apr 1, 2020

This PR ensures that

  1. all node modules get transpiled to es5 (needed for fast-csv and saxes)
  2. unicode regex patterns are supported (needed for a dependency of saxes)

I've tested this on IE11 and can confirm that it fixes #1177

@alubbe alubbe mentioned this pull request Apr 1, 2020
Closed
@Siemienik Siemienik merged commit 2efaeac into exceljs:master Apr 7, 2020
@mydea mydea mentioned this pull request Apr 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guyonroche guyonroche Awaiting requested review from guyonroche

@Siemienik Siemienik Awaiting requested review from Siemienik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alubbe @Siemienik