Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix index.d.ts #1092

Merged
merged 4 commits into from
Feb 6, 2020
Merged

Fix index.d.ts #1092

merged 4 commits into from
Feb 6, 2020

Conversation

Siemienik
Copy link
Member

master: master ? master.address : undefined,

@Siemienik
Copy link
Member Author

I have the second bug, getter fullAddress.adress is a string and is not an Address

new Cell(null, null, 'A1');

https://github.com/exceljs/exceljs/blob/master/lib/doc/cell.js#L22

https://github.com/exceljs/exceljs/blob/master/lib/doc/cell.js#L272

@Siemienik
Copy link
Member Author

I've just added next typing fixations (for Column interface)

Siemienik pushed a commit to Siemienik/xlsx-renderer that referenced this pull request Jan 26, 2020
@Siemienik Siemienik requested a review from guyonroche January 31, 2020 12:02
@alubbe alubbe merged commit b35e9de into master Feb 6, 2020
@alubbe alubbe deleted the f/typings-fix branch February 6, 2020 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants