New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typings for cell.note #1058

Merged

Siemienik merged 3 commits into exceljs:master from artemovskiy:master

Jan 11, 2020

Contributor

artemovskiy commented Dec 20, 2019

There were issue that cell comments are accessible by Cell.note property, but in index.d.ts were "comments" instead of "note".

artemovskiy added 2 commits

December 20, 2019 12:37


          fix typings for cell.note

ad48de5


          increase version

ef53d45

Member

Siemienik commented Jan 11, 2020

Could you remove version increasing? it's not required here, scripts care about that 😸

ofc, You have right with typings :)
https://github.com/exceljs/exceljs/blob/master/lib/doc/cell.js#L222


          Update package.json

817f174

Siemienik merged commit 1c3ea65 into exceljs:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet