fix: keep customData when converting to ExcalidrawElement (#7654) #7656
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
| opts, | ||
| ); | ||
| convertedElements.forEach((ele) => { | ||
| expect(ele.customData).not.toBeDefined(); |
There was a problem hiding this comment.
separate test not needed, its already recorded in snapshot
| text: "Hello", | ||
| }, | ||
| { | ||
| type: "image", |
There was a problem hiding this comment.
just a single element is enough, also lets move this test towards the end
yubinTW
force-pushed
the
feature/keep-customDate
branch
from
b7698be to
63f5fc3
Compare
|
Hi @ad1992, |
|
@ad1992 can this be merged? |
ad1992
changed the title
yubinTW
force-pushed
the
feature/keep-customDate
branch
from
c4dbac9 to
3204876
Compare
|
Hi @ad1992 |
|
@ad1992 when can we expect patch with those changes? |
very soon, I will check if there is anything else we should push to patch and release by tonight/tomorrow. |
|
@ad1992 how can I know that the patch is out? |
I will be sharing here once the patch is released so post that you can update it |
* feat: keep customData when converting to ExcalidrawElement (#7654) * docs: add changelog for keeping customData when converting to ExcalidrawElement
|
The patch is released, you can update the excalidraw version to |
…#7656) * feat: keep customData when converting to ExcalidrawElement (excalidraw#7654) * docs: add changelog for keeping customData when converting to ExcalidrawElement
patch release * tag 'v0.17.5': v0.17.5 fix: parse embeddable srcdoc urls strictly & escape attribute url html v0.17.4 fix: Gist embed allowing unsafe html (excalidraw#7883) fix: keep customData when converting to ExcalidrawElement (excalidraw#7656) fix: umd build so it can be used in browser (excalidraw#7349) fix: disable caching bounds for arrow labels (excalidraw#7343) fix: bounds cached prematurely resulting in incorrectly rendered labels (excalidraw#7339) docs: upgrade to @excalidraw/excalidraw@0.17.0 (excalidraw#7285)
for #7654
if
customDataof anExcalidrawElementSkeletonis provided, when usingconvertToExcalidrawElements()to convertExcalidrawElementSkeletontoExcalidrawElement, it will not disappear.