Center element on paste #248
Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/vjeux/excalidraw/h13i758js |
|
@dwelle I hope this one should work |
|
Alright, this one works. Although, when you copy/paste several times, it pastes over the same position which may be hard to notice. Some older implem did offset it a bit, what do you think? (You'd still need to check that it doesn't move off-screen by the offset). |
|
Well, I'm using Sketch right now and it has the same behavior, if we offset if, we might end being off-screen. So I think the current implementation is just fine! |
Fausto95
force-pushed
the
paste-in-center
branch
from
0803c8d to
ff2885a
Compare
| if (x == null) x = 10 - this.state.scrollX; | ||
| if (y == null) y = 10 - this.state.scrollY; | ||
| const minX = Math.min(...parsedElements.map(element => element.x)); | ||
| const minY = Math.min(...parsedElements.map(element => element.y)); |
There was a problem hiding this comment.
You can't remove this. It is useful for pasting multiple elements
Fausto95
force-pushed
the
paste-in-center
branch
from
ff2885a to
0fee157
Compare
|
Doesn't seem to be working as expected, it pastes on the bottom-left'ish corner
|
Bottom-right'ish, you mean? @Fausto95 I'd simply compute the selection's bounding area (check my algo in exportAsPNG, but use only selected elems), and paste them at the same location + offset, except when the bounding area would get off-screen, in which case decrease the offset so that it doesn't (there might be an edge case where you can't offset at all without screen-overflow, in which case I'd offset anyway -- the offset shouldn't be much more than +-10px, anyway). I'm actually not sure what was wrong with previous implem from @vjeux (apart from pasted position possibly being off-screen by a few px)? |
It's correctly centered with your algo, but when it comes to pasting multiple elements, it completely messes up the position they were when copied EDITED: |
|
Now it is pasting under(well, right next) the mouse position @vjeux let me know if this seems ok-ish. |
|
It doesn't seem to be working as intended. It takes the delta between top left of screen and element, and reproduces this to cursor to element. So if you have an element outside of the top left, it's going to be pasted far away from the cursor. What we want is to take the center of the element(s) we're pasting, and make this be at the position of the mouse.
|
|
Would be great to ship this relatively soon, the current behavior of moving the element at the top left is very annoying |
|
It's working now |
|
Nice, just tested and it's working well! |
Fixes #164