Fix crashes on large numbers of connections #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All three fd_set arguments to select must be large enough to modify according to the length given in the first argument to select. This can be done by calling rb_fd_resize on each of the fd_set arguments, which happens to be exactly what rb_fd_select does!
This was referenced May 6, 2018
Closed
sodabrew
changed the title
This was referenced May 6, 2018
Closed
sodabrew
added a commit
that referenced
this pull request
May 12, 2018
All three fd_set arguments to select must be large enough to modify according to the length given in the first argument to select. This can be done by calling rb_fd_resize on each of the fd_set arguments, which happens to be exactly what rb_fd_select does!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All three fd_set arguments to select must be large enough to modify
according to the length given in the first argument to select. This can
be done by calling rb_fd_resize on each of the fd_set arguments, which
happens to be exactly what rb_fd_select does!