ssl: c++: be verbose about SSL connection errors #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ideally we could pass those errors up inside of an Exception, if one would be generated from this type of error, or as a callback to a logging method that the user can provide. But stderr is better than swallowing errors whole. |
|
I agree that exception is more preferrable, but those couple of exceptions in this file seems like placed "just to have an exception". :) There are several more situations to cover. What I proposed solves problem in my personal case. Generic fix is up to project team of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows more easy debugging of applications that use eventmachine (native mode) with SSL.
Example of the output: