Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extconf.rb to allow MinGW builds with OpenSSL 1.1.0 #785

Merged
merged 1 commit into from
May 22, 2017

Conversation

MSP-Greg
Copy link
Contributor

Windows libraries are renamed in OpenSSL 1.1.0.

@MSP-Greg MSP-Greg mentioned this pull request May 22, 2017
when /mswin|mingw|bccwin/ ; %w(ssleay32 libeay32)
else ; %w(crypto ssl)
end
SSL_LIBS = %w(crypto ssl)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment here:

# OpenSSL 1.1.0 and above for Windows use the Unix library names
# OpenSSL 0.9.8 and 1.0.x for Windows use these older library names

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sodabrew done

@sodabrew sodabrew added this to the v1.2.4 milestone May 22, 2017
@sodabrew sodabrew merged commit 0c3e9e2 into eventmachine:master May 22, 2017
@sodabrew
Copy link
Member

Thank you!

@MSP-Greg
Copy link
Contributor Author

@sodabrew And thank you also. I'm one of those picky doc types, so I added EM to my doc site. I fixed the issue YARD (no PR there yet) had with cpp files, and also added the wiki files. You might find it helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants