Close socket on close_connection even after close_connection_after_writing #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...even if we have previously asked to close later. Many places in the codebase use ScheduleClose(false) when they have found out that the socket is no longer operational, but they are being ignored if ScheduleClose(true) has been used in the past. As the socket is often not working at this point, we will never get through the send queue and actually do the close.
|
Thank you! |
sodabrew
added a commit
that referenced
this pull request
Mar 11, 2016
Close socket on close_connection even after close_connection_after_writing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, calls to close now were ignored if a close was scheduled for after we finish writing. This was problematic in any case where a graceful close was scheduled, but the send buffer might never be consumed, for example: