Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added windows IPv6 support #303

Closed
wants to merge 13 commits into from
Closed

Conversation

stakach
Copy link

@stakach stakach commented Mar 6, 2012

Also increased file and socket limits

@stakach
Copy link
Author

stakach commented Mar 7, 2012

@tmm1 just thought I'd let you know that I've completely solved the issues with connection weirdness and eventmachine on windows.

The FD_SETSIZE must be the same on ruby installer as it is in eventmachine.
The next release of ruby installer will increase the limit to 32767 so this must be reflected in project.h
Previous versions of ruby installer ruby will continue to work as they used to.

Thanks for your on going help in the matter. Very much appreciated and helpful.
I'll also stop harassing you now too. ;)

@stakach
Copy link
Author

stakach commented Mar 7, 2012

The ruby installer issue oneclick/rubyinstaller#104

@stakach
Copy link
Author

stakach commented Mar 8, 2012

@tmm1 the final product rolled out at Sydney University running on eventmachine and rubyinstaller ruby.
I did a little write up on the project.

https://groups.google.com/forum/?fromgroups#!topic/rubyinstaller/0UlbSlwXa6U

@rdp
Copy link

rdp commented Mar 8, 2012

why does it have to match the rubyinstaller FD_SETSIZE again?

@stakach
Copy link
Author

stakach commented Mar 8, 2012

From observations on Windows 2008 R2 x64 VM

  1. Ruby SETSIZE < EM SETSIZE
  • Ruby SETSIZE is enforced
  • Unpredictable behaviour beyond Ruby SETSIZE (at one point I had sockets surviving program termination that remained ESTABLISHED)
    1. Ruby SETSIZE > EM SETSIZE
  • segfault

@alor
Copy link

alor commented Apr 24, 2012

have you tested it with rubyinstaller 1.9.3-p194 ?
i'm having some problems with it... see #319.

@Azolo
Copy link

Azolo commented May 10, 2012

@stakach Since 8840d22 solves #319 and could be considered a fix this is beyond the scope of just this PR think you could extract it into a new one?

@stakach
Copy link
Author

stakach commented May 10, 2012

Well the aim of this pull request was to improve windows support on eventmachine.

@tmm1 is there any reason we can't merge these changes and create a new windows release?

@stakach
Copy link
Author

stakach commented May 10, 2012

@raggi maybe you could help?

@sodabrew
Copy link
Member

Note to self: Check if #570 includes this work.

@sodabrew sodabrew added this to the v1.2.0 milestone Aug 11, 2015
@sodabrew
Copy link
Member

Superseded by #630

@sodabrew sodabrew closed this Aug 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants