Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests require Internet access #656

Closed
davexunit opened this issue Nov 9, 2015 · 1 comment
Closed

Tests require Internet access #656

davexunit opened this issue Nov 9, 2015 · 1 comment
Milestone
v1.2.2

Comments

@davexunit
Copy link

The test suite tries to connect to google.com for some of the tests, causing the test suite to fail if there is no Internet connection or there is a transient networking issue, which is rather brittle. It would be good if such tests were skipped in the event that google.com does not resolve, and even better if the tests didn't require network access at all, assuming only the local loopback device. Thoughts?
@sodabrew
Copy link
Member

Significant progress on removing third-party sites from tests in #749.

@sodabrew sodabrew added this to the v1.2.2 milestone Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.2
Development

No branches or pull requests
2 participants
@sodabrew @davexunit