-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore/url-builder-client-server-compatible #859
Merged
boyney123
merged 12 commits into
event-catalog:main
from
carlosallexandre:chore/url-builder-client-server-compatible
Oct 16, 2024
Merged
chore/url-builder-client-server-compatible #859
boyney123
merged 12 commits into
event-catalog:main
from
carlosallexandre:chore/url-builder-client-server-compatible
Oct 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a3767a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
It adds the global variable to run url-builder utility either in node and browser environments.
carlosallexandre
force-pushed
the
chore/url-builder-client-server-compatible
branch
from
October 11, 2024 13:47
48f4616
to
a4b16b8
Compare
Thank you @carlosallexandre such a better implementation and idea, didnt even know this was possible. Thank you mate! |
carlosallexandre
deleted the
chore/url-builder-client-server-compatible
branch
November 7, 2024 18:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After investigating the issue #847, I found that
url-builder
is imported by a client component (Table
component used bydiscover page
). Asurl-builder
depends on thetrailingSlash
config to generate the appropriately url, running theurl-builder
in browser environments causes the error mentioned in the issue.A few client components use
url-builder-client
that doesn't rely on the@eventcatalog.config
but needs thetrailingSlash
as a param. This brings a burden to the client component as it needs to know thetrailingSlash
needed only to theurl-builder
that is passed by a server component through props.So, to remove the unneeded trailingSlash props and avoiding the duplication of
url-builder
this PR adds a global variable (__EC_TRAILING_SLASH__
) that can be acessed by theurl-builder
in node/browser environments without any issue.Fix #847.