Feat/fix domain visualization #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 178f1f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
XaaXaaX
force-pushed
the
feat/fix-domain-visualization
branch
2 times, most recently
from
3109db4 to
2954409
Compare
XaaXaaX
force-pushed
the
feat/fix-domain-visualization
branch
from
2954409 to
88488e1
Compare
|
Very nice! Much better <3 |
|
Thank you @XaaXaaX |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The domain visualizer rendering and layout has some overlapping and incostistent positioning, The domain viz is the most complext one in EC and it shows a more global landscape than service or messages do
The solution was to use the same calculate Node in @utils that consider defining the position of each node in graph
Old results
New Results