Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Synapse-Admin shows generic errors when an error is returned from Synapse API. But Synapse Admin API uses error format from the Matrix specification.
Please add a global error handler, that will attempt to parse the Matrix error from the response, and if failed, just return the whole response as an error message.
The format should be the following:
<errcode> (<http status code>): <error>
, example:M_MISSING_PARAM (400): parameter is missing
Example: invalid credentials
Authentication failed, please retry
{"errcode":"M_FORBIDDEN","error":"Invalid username or password"}
It should show
M_FORBIDDEN (403): Invalid username or password