-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changelog to ETJump menus #1532
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing this in CMake means we don't need to actually bundle the changelog.md with the mod
ETJump -> Changelog displays the changelog from a given version (selectable via dropdown menu) in a scrollable textbox. This also fixes a bunch of hardcoded values from the dropdown menu implementation, making it much more portable outside of the ETJump settings menu layout.
…headers.h The macro is not needed, initially thought I'd need the headers too but that was not the case. Including a header guard to version_headers.h since it gets included in ui_main.cpp for reading the changelog files.
Make some of the older entries have proper indentation like newer ones. Handle bolded text before transforming line starts from * to -, to not break lines starting with ''* **X**'
UI parsers don't support #pragma once
Replaces them with a color escape so they are displayed normally
Just having the numeric version is cleaner and enough.
Now that it's used to parse the changelog assets, it makes sense to run CI whenever it's updated.
Aciz
force-pushed
the
changelog-menu-ui
branch
from
November 13, 2024 19:54
d67d4e1
to
387bcb3
Compare
Use slightly brighter background color in FUI, the readability is fine without the darker background in menus.
Aciz
force-pushed
the
changelog-menu-ui
branch
from
November 14, 2024 04:32
b3a5967
to
20d0ec2
Compare
Aciz
force-pushed
the
changelog-menu-ui
branch
from
November 14, 2024 04:53
f351527
to
98e2800
Compare
Was supposed to remove changelog.md instead of .clang_format from the ignored list
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Nov 14, 2024
This was referenced Nov 14, 2024
This was referenced Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog.md
and outputs separate plaintext changelog files for each version intoassets/ui/changelog/
- no need to bundle the actual changelog file with the mod, or maintain 2 separate changlogsstd::map
, so they don't eat a massive chunk of UI string poolETJump -> Changelog
fixes #169