Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix panic in epochCache.loadEpochStats #118

Merged
merged 1 commit into from
Aug 28, 2024
Merged

fix panic in epochCache.loadEpochStats #118

merged 1 commit into from
Aug 28, 2024

Conversation

pk910
Copy link
Member

@pk910 pk910 commented Aug 28, 2024

fix panic from peerdas devnet:

panic: runtime error: integer divide by zero

goroutine 966 [running]:
github.com/ethpandaops/dora/indexer/beacon.(*epochCache).loadEpochStats(0xc0001461b0, 0xc000594270)
	/home/runner/work/dora/dora/indexer/beacon/epochcache.go:436 +0x9ea
created by github.com/ethpandaops/dora/indexer/beacon.(*epochCache).runLoaderLoop in goroutine 94
	/home/runner/work/dora/dora/indexer/beacon/epochcache.go:369 +0x145

This is happening when dora tries loading the epoch stats of a fork that no client is part of.
This might happen in networks with high amount of reorgs (peerdas forkparties).
Such epoch stats should be ignored after several silent retries

@pk910 pk910 requested a review from skylenet August 28, 2024 11:49
@pk910 pk910 merged commit 042e560 into master Aug 28, 2024
1 check passed
@pk910 pk910 deleted the pk910/fix-panic-1 branch August 28, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skylenet skylenet skylenet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pk910 @skylenet