Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken mev indexer #113

Merged
merged 6 commits into from
Aug 26, 2024
Merged

fix broken mev indexer #113

merged 6 commits into from
Aug 26, 2024

Conversation

pk910
Copy link
Member

@pk910 pk910 commented Aug 23, 2024

... by actually starting it 😅 + 2 small fixes

@pk910 pk910 added the build-docker-image Automatically build docker image for PR branch label Aug 23, 2024
@pk910
Copy link
Member Author

pk910 commented Aug 23, 2024

tested here: https://dora-holesky.pk910.de/mev/blocks

@pk910 pk910 marked this pull request as draft August 23, 2024 12:46
@pk910
Copy link
Member Author

pk910 commented Aug 23, 2024

not ready yet :/
shows proposed blocks as orphaned

@pk910 pk910 marked this pull request as ready for review August 24, 2024 21:28
@pk910
Copy link
Member Author

pk910 commented Aug 24, 2024

ready now :)
problem was related to the new indexer code which updated the proposed status of mev blocks as part of the finalization routine.
the code used the roots of the canonical blocks to update mev blocks, however mev blocks are identified by their EL block hash.
as no block hash matches any of the provided canonical roots, all blocks were marked as orphaned

@pk910 pk910 removed the build-docker-image Automatically build docker image for PR branch label Aug 24, 2024
@pk910 pk910 merged commit 65baf7d into master Aug 26, 2024
12 checks passed
@pk910 pk910 deleted the pk910/add-mev-indexer branch August 26, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants