Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix some build warnings #1331

Merged
merged 3 commits into from
Apr 15, 2019
Merged

Conversation

veox
Copy link
Contributor

@veox veox commented Apr 15, 2019

What was wrong?

Building docs produces warnings.

How was it fixed?

As warnings suggest: remove unneeded whitespace, fix indentation, comment out unused setting.

This does not address issue #1330. It only fixes the other warnings.

OK to squash-merge.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Source: Felicia of Fermilab, via AO

/home/veox/src/web3.py/docs/web3.parity.rst:129: WARNING: Block quote ends without a blank line; unexpected unindent.
/home/veox/src/web3.py/docs/providers.rst:100: WARNING: Unexpected indentation.
copying static files... WARNING: html_static_path entry '/home/veox/src/web3.py/docs/_static' does not exist
@veox veox changed the title Docs: fix some warnings Docs: fix some build warnings Apr 15, 2019
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @veox! This looks good to me!

@kclowes kclowes merged commit 29cbed6 into ethereum:master Apr 15, 2019
@veox veox deleted the doc-fix-warnings branch April 15, 2019 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants