Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated methods #1232

Merged
merged 5 commits into from
Feb 11, 2019
Merged

Remove deprecated methods #1232

merged 5 commits into from
Feb 11, 2019

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Feb 5, 2019

What was wrong?

Needed to remove deprecated methods for v5

Related to Issue #
#722

How was it fixed?

Removed them!

Cute Animal Picture

unusual-animal-friendship-4-1

@kclowes kclowes changed the title Rm deprecated methods Remove deprecated methods Feb 5, 2019
@carver carver mentioned this pull request Feb 5, 2019
Closed
22 tasks
pipermerriam
pipermerriam approved these changes Feb 5, 2019
View reviewed changes
Copy link
Member

@pipermerriam pipermerriam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a really nice swath of deletions.

Need to make sure we include an explicit list of these removed messages in the release notes. You might go ahead and make an unreleased section and start listing these there.

@kclowes kclowes merged commit 28129dd into ethereum:master Feb 11, 2019
@kclowes kclowes deleted the rm-deprecated-methods branch February 11, 2019 18:22
@kclowes kclowes mentioned this pull request Feb 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pipermerriam pipermerriam pipermerriam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kclowes @pipermerriam