cmd, consensus/ethash, eth: miner push notifications #17347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
force-pushed
the
miner-notify
branch
2 times, most recently
from
dc470bf to
dda1f91
Compare
|
@ppratscher @rjl493456442 PTAL |
rjl493456442
reviewed
Aug 9, 2018
| // getWork returns a work package for external miner. | ||
| for i, url := range notify { | ||
| // Terminate any previously pending request and create the new work | ||
| if notifyReqs[i] != nil { |
There was a problem hiding this comment.
Should we set the notifyReq[i] as nil if the request has been sent successfully?
There was a problem hiding this comment.
That would be racey. To be fair however, this current code might be racey too. I'll think about it.
|
LGTM! |
|
Just one comment, otherwise LGTM |
|
@rjl493456442 I fixed the data race by passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new flag
--miner.notify, which accepts a comma-separated list of URLs to push miner work packages to. It's main use case is for mining pools to be pinged by new blocks as fast as possible, without requiring to constantly poll theminer.getWorkendpoint.Supersedes #17324.