Support RTL (Initial) #6415
Merged
Support RTL (Initial) #6415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add dir attribute on Links
Make footer links change direction based on locale
Change Dropdown caret position based on locale
nikkhielseath
requested review from
samajammin,
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
|
I am using "auto" as the direction when it is RTL language as the same would help in case the content is a mixture of both LTR and RTL language. For Example, in the footer, some links are in English and some are in Arabic. |
|
(The issue with code-examples is already taken care of by some other change) |
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 29m PerformanceLighthouse report
|
|
A conflict. |
minimalsm
approved these changes
Jun 8, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This merge will fix the home page to better support RTL languages
The support for the RTL graph is not a part of this PR as configuring Recharts is more cumbersome than thought.
Related Issue