Use statbuf structure directly to store the handful of stat derived values #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in DocumentInfo to track various attributes of the document. Unfortunately, this structure is very OS specific. So supporting it properly was going to require a lot of #ifdefs... So better to just use statbuf to store them! Will also with issue #252 since several of the errors there was regarding not knowing the types for OS/2 versions of these fields.
1div0
pushed a commit
to 1div0/nedit-ng
that referenced
this pull request
Mar 24, 2021
…alues (eteran#298) * The majority of the fields in a statbuf were being replicated in DocumentInfo to track various attributes of the document. Unfortunately, this structure is very OS specific. So supporting it properly was going to require a lot of #ifdefs... So better to just use statbuf to store them! Will also with issue eteran#252 since several of the errors there was regarding not knowing the types for OS/2 versions of these fields. * formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The majority of the fields in a statbuf were being replicated
in DocumentInfo to track various attributes of the document.
Unfortunately, this structure is very OS specific. So supporting
it properly was going to require a lot of #ifdefs...
So better to just use statbuf to store them!
Will also with issue #252 since several of the errors there was
regarding not knowing the types for OS/2 versions of these fields.