Refactored fixed with font to be more robust (#234) #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NEdit classic applied fixed-width fonts as a design decision to all text-entry fields. This was done with a VendorShell resource which categorized fonts into button fonts, label fonts, text fonts, etc. Here we use QWidget class-based defaults which is the closest thing.
|
Nice, I had no idea you could apply fonts to a widget type by string like that., |
1div0
pushed a commit
to 1div0/nedit-ng
that referenced
this pull request
Mar 24, 2021
NEdit classic applied fixed-width fonts as a design decision to all text-entry fields. This was done with a VendorShell resource which categorized fonts into button fonts, label fonts, text fonts, etc. Here we use QWidget class-based defaults which is the closest thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEdit classic applied fixed-width fonts as a design decision to all
text-entry fields. This was done with a VendorShell resource which
categorized fonts into button fonts, label fonts, text fonts, etc.
Here we use QWidget class-based defaults which is the closest thing.