Tab reorder + deleted files = wrong tab names fix! #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trigger a "save/cancel" dialog (such as when files have been deleted) that are tabs without focus right now) we can end up with the wrong names on tabs! so we sort BEFORE we update the tab state just to be sure everything is in the right spots! Fixes issue #224
Closed
1div0
pushed a commit
to 1div0/nedit-ng
that referenced
this pull request
Dec 29, 2020
…trigger a "save/cancel" dialog (eteran#225) (such as when files have been deleted) that are tabs without focus right now) we can end up with the wrong names on tabs! so we sort BEFORE we update the tab state just to be sure everything is in the right spots! Fixes issue eteran#224
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
weird bug! When a new tab causes a reordering AND a focus event will trigger a "save/cancel" dialog
(such as when files have been deleted) that are tabs without focus right now)
we can end up with the wrong names on tabs!
so we sort BEFORE we update the tab state just to be sure everything is in the right spots!
Fixes issue #224