[1.0.5] Make looptask stack size configurable #4564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added guarded define to set the stacksize on the main looptask. Advantage of this is that build_flags can be used to provide a different value for the stack size should it be neccessary default behaviour is unaffected
me-no-dev
reviewed
Dec 1, 2020
cores/esp32/main.cpp
Outdated
| @@ -3,6 +3,10 @@ | |||
| #include "esp_task_wdt.h" | |||
| #include "Arduino.h" | |||
|
|
|||
| #ifndef LOOP_STACK_SIZE | |||
There was a problem hiding this comment.
please rename to CONFIG_ARDUINO_LOOP_STACK_SIZE so I can add this to the IDF Kconfig as well
me-no-dev
changed the title
changed variable name to CONFIG_ARDUINO_LOOP_STACK_SIZE as requested by @me-no-dev
|
thanks :) |
This was referenced Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added guarded define to set the stacksize on the main looptask.
Advantage of this is that build_flags can be used to provide a different value for the stack size should it be neccessary
default behaviour is unaffected