Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lvgl] Fix msgbox content #7912

Merged
merged 2 commits into from
Dec 3, 2024
Merged

[lvgl] Fix msgbox content #7912

merged 2 commits into from
Dec 3, 2024

Conversation

clydebarrow
Copy link
Contributor

@clydebarrow clydebarrow commented Dec 3, 2024 •
edited
Loading

What does this implement/fix?

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests
  • Other

Related issue or feature (if applicable):

Pull request in esphome-docs with documentation (if applicable):

  • esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx
  • host

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@clydebarrow clydebarrow added this to the 2024.11.3 milestone Dec 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.80%. Comparing base (4d8b5ed) to head (5868105).
Report is 1739 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #7912      +/-   ##
==========================================
+ Coverage   53.70%   53.80%   +0.09%     
==========================================
  Files          50       50              
  Lines        9408     9813     +405     
  Branches     1654     1353     -301     
==========================================
+ Hits         5053     5280     +227     
- Misses       4056     4207     +151     
- Partials      299      326      +27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesserockz jesserockz enabled auto-merge (squash) December 3, 2024 20:29
@jesserockz jesserockz merged commit a37ff2d into esphome:dev Dec 3, 2024
29 checks passed
@clydebarrow clydebarrow deleted the lvgl-fixes branch December 3, 2024 20:52
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jesserockz jesserockz jesserockz approved these changes

Assignees
No one assigned
Labels
by-code-owner cherry-picked has-tests integration: lvgl small-pr
Projects
None yet
Milestone
2024.11.3
Development

Successfully merging this pull request may close these issues.
3 participants
@clydebarrow @codecov-commenter @jesserockz