Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lvgl] Make image update via lambda work #7886

Merged
merged 6 commits into from
Nov 28, 2024
Merged

[lvgl] Make image update via lambda work #7886

merged 6 commits into from
Nov 28, 2024

Conversation

clydebarrow
Copy link
Contributor

What does this implement/fix?

Image sources could not be effectively updated via lambda (in spite of there being a test case for it - it was not being compiled.)

  • Enable image update via lambda
  • Enable animimg update via lambda

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests
  • Other

Related issue or feature (if applicable):

  • fixes

Pull request in esphome-docs with documentation (if applicable):

  • esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx
  • host

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.80%. Comparing base (4d8b5ed) to head (ccac887).
Report is 1721 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #7886      +/-   ##
==========================================
+ Coverage   53.70%   53.80%   +0.09%     
==========================================
  Files          50       50              
  Lines        9408     9812     +404     
  Branches     1654     1353     -301     
==========================================
+ Hits         5053     5279     +226     
- Misses       4056     4207     +151     
- Partials      299      326      +27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@probot-esphome probot-esphome bot removed the small-pr label Nov 28, 2024
@jesserockz jesserockz merged commit c9b0490 into esphome:dev Nov 28, 2024
25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2024
@clydebarrow clydebarrow deleted the lvgl-image branch January 13, 2025 06:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jesserockz jesserockz jesserockz approved these changes

Assignees
No one assigned
Labels
by-code-owner has-tests integration: lvgl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clydebarrow @codecov-commenter @jesserockz