Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http_request] Fix within context with parameters. (Bugfix) #7790

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

clydebarrow
Copy link
Contributor

@clydebarrow clydebarrow commented Nov 20, 2024

What does this implement/fix?

Fixes issue introduced by previous PR..

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests
  • Other

Related issue or feature (if applicable):

Pull request in esphome-docs with documentation (if applicable):

  • esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml
script:  
  - id: does_not_compile
    parameters:
      api_url: string
    then:
      - http_request.get:
          url: "http://google.com"

http_request:

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@jzucker2
Copy link
Contributor

Thank you! I thought I was going crazy

@clydebarrow clydebarrow modified the milestones: 2024.11.0b5, 2024.11.1 Nov 20, 2024
@jesserockz jesserockz merged commit 6d4f787 into esphome:dev Nov 21, 2024
29 checks passed
@jesserockz jesserockz mentioned this pull request Nov 21, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants