Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sensor] Make some values templatable #7735

Merged
merged 2 commits into from
Nov 11, 2024
Merged

[sensor] Make some values templatable #7735

merged 2 commits into from
Nov 11, 2024

Conversation

clydebarrow
Copy link
Contributor

What does this implement/fix?

The filters:

  • timeout
  • offset
  • multiply
  • filter_out

now take a templatable value. In addition, filter_out will now take a list of values to filter on.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests
  • Other

Related issue or feature (if applicable):

  • fixes

Pull request in esphome-docs with documentation (if applicable):

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@clydebarrow clydebarrow requested a review from a team as a code owner November 8, 2024 10:57
@probot-esphome
Copy link

probot-esphome bot commented Nov 8, 2024

Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration (sensor) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@clydebarrow clydebarrow mentioned this pull request Nov 8, 2024
Merged
3 tasks
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.81%. Comparing base (4d8b5ed) to head (835198e).
Report is 1569 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #7735      +/-   ##
==========================================
+ Coverage   53.70%   53.81%   +0.10%     
==========================================
  Files          50       50              
  Lines        9408     9795     +387     
  Branches     1654     1351     -303     
==========================================
+ Hits         5053     5271     +218     
- Misses       4056     4198     +142     
- Partials      299      326      +27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesserockz jesserockz merged commit d885d65 into esphome:dev Nov 11, 2024
39 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2024
@clydebarrow clydebarrow deleted the filter-templates branch January 14, 2025 21:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jesserockz jesserockz jesserockz approved these changes

Assignees
No one assigned
Labels
core has-tests integration: sensor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clydebarrow @codecov-commenter @jesserockz