-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[es8311] Add es8311 dac component #7693
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #7693 +/- ##
==========================================
+ Coverage 53.70% 53.99% +0.28%
==========================================
Files 50 50
Lines 9408 9766 +358
Branches 1654 1344 -310
==========================================
+ Hits 5053 5273 +220
- Misses 4056 4167 +111
- Partials 299 326 +27 ☔ View full report in Codecov by Sentry. |
Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration ( |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
What does this implement/fix?
Adds support for the ES8311 codec chip as an
audio_dac
component. The S3 Box 3 uses this for handling audio output. It supports volume and mute control in hardware.I built this from the unmerged #4861, and so I listed @kroimon as a codeowner. If you would prefer not to be included, please let me know. I adapted that code to the
audio_dac
platform and exposed more yaml configuration options.Note that this only handles audio out on the S3 box, not audio in. So it only removes the requirement for the
esp_adf
component's speaker. I haven't tested pairing this component with theesp_adf
microphone in a voice assistant, so that may not work!Requires the already merged #7664 to handle volume control with the speaker component.
Types of changes
Related issue or feature (if applicable):
Pull request in esphome-docs with documentation (if applicable):
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: