[nextion] Add publish actions #7646

pkejval · 2024-10-21T08:41:51Z

What does this implement/fix?

Adds YAML actions for publishing states of various Nextion sensors. This functionality was available only in lambdas.

Types of changes

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Code quality improvements to existing code or addition of tests
Other

Related issue or feature (if applicable):

none

Pull request in esphome-docs with documentation (if applicable):

Add publish Action for Nextion components esphome-docs#4368

Test Environment

Example entry for `config.yaml`:

esphome:
  name: test2
  on_boot: 
    then:
      - sensor.nextion.publish:
          id: nex_float
          state: 1
          publish_state: false
          send_to_nextion: true

      - binary_sensor.nextion.publish:
          id: nex_binary
          state: True

      - text_sensor.nextion.publish:
          id: nex_text
          state: "TEST"

      - switch.nextion.publish:
          id: nex_switch
          state: True

esp32:
  board: wemos_d1_mini32
  framework:
    type: esp-idf

logger:
api:
ota:
  platform: esphome

wifi:
  ssid: !secret wifi
  password: !secret wifi_pass
  reboot_timeout: 0s

external_components:
  - source: github://pr#7646
    components: [ nextion ]

sensor:
  - platform: nextion
    id: nex_float
    nextion_id: nex
    component_name: test.float
    precision: 0

binary_sensor:
  - platform: nextion
    id: nex_binary
    component_name: test.binary

text_sensor:
  - platform: nextion
    id: nex_text
    component_name: test.text

switch:
  - platform: nextion
    id: nex_switch
    component_name: test.switch

uart:
  - id: ser
    rx_pin: GPIO16
    tx_pin: GPIO17
    baud_rate: 115200

display:
  - platform: nextion
    id: nex
    uart_id: ser

Checklist:

The code change is tested and works locally.
Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in esphome-docs.

probot-esphome · 2024-10-21T08:41:58Z

Hey there @edwardtfn, @SenexCrenshaw, mind taking a look at this pull request as it has been labeled with an integration (nextion) you are listed as a code owner for? Thanks!
_{^{(message by CodeOwnersMention)}}

codecov-commenter · 2024-10-21T08:43:15Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.76%. Comparing base (4d8b5ed) to head (bb00644).
Report is 1639 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #7646      +/-   ##
==========================================
+ Coverage   53.70%   53.76%   +0.05%     
==========================================
  Files          50       50              
  Lines        9408     9805     +397     
  Branches     1654     1354     -300     
==========================================
+ Hits         5053     5272     +219     
- Misses       4056     4207     +151     
- Partials      299      326      +27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests

kbx81

LGTM -- @edwardtfn any thoughts/comments?

edwardtfn · 2024-10-25T03:17:07Z

It looks awesome.

kbx81 · 2024-10-30T04:28:17Z

One final thought/request @pkejval -- please update the tests for this component to include these actions.

Needs tests updated

pkejval · 2024-11-01T06:39:32Z

I wrote some tests but I have no idea how to run them. Cannot find any documentation about it. Can you give me advice, please?

kbx81 · 2024-11-03T07:30:39Z

From the root of the repo: ./script/test_build_components -e compile -c nextion

tests/components/nextion/test.esp32-ard.yaml

kbx81

Fixes so tests will work

tests/components/nextion/test.esp32-ard.yaml

tests/components/nextion/test.esp32-c3-ard.yaml

tests/components/nextion/test.esp32-c3-idf.yaml

tests/components/nextion/test.esp32-idf.yaml

tests/components/nextion/test.esp8266-ard.yaml

tests/components/nextion/test.rp2040-ard.yaml

esphome · 2024-11-17T07:36:12Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

kbx81

Fix binary sensor IDs in tests

tests/components/nextion/common.yaml

kbx81 · 2024-11-17T07:57:44Z

tests/components/nextion/test.rp2040-ard.yaml

-    on_page:
-      then:
-        lambda: 'ESP_LOGD("display","Display shows new page %u", x);'
+wifi: !remove


HTTP client requires wifi

tests/components/nextion/test.rp2040-ard.yaml

probot-esphome · 2024-11-17T09:02:35Z

Hey there @SenexCrenshaw, mind taking a look at this pull request as it has been labeled with an integration (nextion) you are listed as a code owner for? Thanks!
_{^{(message by CodeOwnersMention)}}

kbx81

LGTM -- thanks!

probot-esphome bot added the integration: nextion label Oct 21, 2024

This was referenced Oct 21, 2024

Add publish Action for Nextion components esphome/esphome-docs#4360

Closed

Add publish Action for Nextion components esphome/esphome-docs#4368

Merged

kbx81 previously approved these changes Oct 24, 2024

View reviewed changes

probot-esphome bot added the has-tests label Nov 1, 2024

edwardtfn mentioned this pull request Nov 17, 2024

[nextion] New trigger on_buffer_overflow #7772

Merged

14 tasks

edwardtfn reviewed Nov 17, 2024

View reviewed changes

tests/components/nextion/test.esp32-ard.yaml Show resolved Hide resolved

kbx81 requested changes Nov 17, 2024

View reviewed changes

esphome bot marked this pull request as draft November 17, 2024 07:36

kbx81 requested changes Nov 17, 2024

View reviewed changes

kbx81 reviewed Nov 17, 2024

View reviewed changes

tests/components/nextion/test.rp2040-ard.yaml Outdated Show resolved Hide resolved

kbx81 changed the title ~~Add Nextion actions~~ [nextion] Add publish actions Nov 17, 2024

kbx81 marked this pull request as ready for review November 17, 2024 09:02

esphome bot requested a review from kbx81 November 17, 2024 09:02

probot-esphome bot assigned edwardtfn Nov 17, 2024

kbx81 previously approved these changes Nov 17, 2024

View reviewed changes

kbx81 added the merge-after-release label Nov 17, 2024

pkejval added 3 commits November 22, 2024 22:14

add actions

a32b399

fix lambda

a505f46

let clang-format do its magic

4fe6c25

pkejval and others added 5 commits November 22, 2024 22:18

unify tests and add for publish action

94d33b8

Fixes so tests will work

f2d792b

Fix binary sensor IDs in tests

8cc7227

Update tests/components/nextion/test.rp2040-ard.yaml

354025d

No HTTP stuff in RP2040 tests

bb00644

kbx81 dismissed their stale review via bb00644 November 23, 2024 04:19

kbx81 force-pushed the nextion_actions branch from bc4b8b2 to bb00644 Compare November 23, 2024 04:19

kbx81 removed the merge-after-release label Nov 23, 2024

kbx81 approved these changes Nov 23, 2024

View reviewed changes

kbx81 merged commit dea297c into esphome:dev Nov 23, 2024
26 checks passed

github-actions bot locked and limited conversation to collaborators Nov 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[nextion] Add publish actions #7646

[nextion] Add publish actions #7646

pkejval commented Oct 21, 2024 •

edited

Loading

probot-esphome bot commented Oct 21, 2024

codecov-commenter commented Oct 21, 2024 •

edited

Loading

kbx81 left a comment

edwardtfn commented Oct 25, 2024

kbx81 commented Oct 30, 2024

pkejval commented Nov 1, 2024

kbx81 commented Nov 3, 2024

kbx81 left a comment

esphome bot commented Nov 17, 2024

kbx81 left a comment

kbx81 Nov 17, 2024

probot-esphome bot commented Nov 17, 2024

kbx81 left a comment

[nextion] Add publish actions #7646

[nextion] Add publish actions #7646

Conversation

pkejval commented Oct 21, 2024 • edited Loading

What does this implement/fix?

Types of changes

Test Environment

Example entry for config.yaml:

Checklist:

probot-esphome bot commented Oct 21, 2024

codecov-commenter commented Oct 21, 2024 • edited Loading

Codecov Report

kbx81 left a comment

Choose a reason for hiding this comment

edwardtfn commented Oct 25, 2024

kbx81 commented Oct 30, 2024

pkejval commented Nov 1, 2024

kbx81 commented Nov 3, 2024

kbx81 left a comment

Choose a reason for hiding this comment

esphome bot commented Nov 17, 2024

kbx81 left a comment

Choose a reason for hiding this comment

kbx81 Nov 17, 2024

Choose a reason for hiding this comment

probot-esphome bot commented Nov 17, 2024

kbx81 left a comment

Choose a reason for hiding this comment

pkejval commented Oct 21, 2024 •

edited

Loading

Example entry for `config.yaml`:

codecov-commenter commented Oct 21, 2024 •

edited

Loading