Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Seeed Studio MR60BHA2 mmWave Sensor #7589

Merged
merged 11 commits into from
Dec 9, 2024
Merged

Add: Seeed Studio MR60BHA2 mmWave Sensor #7589

merged 11 commits into from
Dec 9, 2024

Conversation

limengdu
Copy link
Contributor

@limengdu limengdu commented Oct 12, 2024 •
edited
Loading

What does this implement/fix?

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#4333

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml
uart:
  id: uart_bus
  baud_rate: 115200
  rx_pin: 17
  tx_pin: 16
  parity: NONE
  stop_bits: 1

seeed_mr60bha2:
  id: my_seeed_mr60bha2

sensor:
  - platform: seeed_mr60bha2
    breath_rate:
      name: "Real-time respiratory rate"
    heart_rate:
      name: "Real-time heart rate"
    distance:
      name: "Distance to detection object"

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.81%. Comparing base (4d8b5ed) to head (9979793).
Report is 1689 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #7589      +/-   ##
==========================================
+ Coverage   53.70%   53.81%   +0.10%     
==========================================
  Files          50       50              
  Lines        9408     9814     +406     
  Branches     1654     1353     -301     
==========================================
+ Hits         5053     5281     +228     
- Misses       4056     4207     +151     
- Partials      299      326      +27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@limengdu limengdu mentioned this pull request Oct 12, 2024
Merged
3 tasks
@limengdu
Copy link
Contributor Author

@jesserockz , please review this PR.

@jesserockz jesserockz requested a review from a team as a code owner November 26, 2024 03:12
@probot-esphome probot-esphome bot added the core label Nov 26, 2024
@jesserockz
Use a different approach to parse the incoming bytes
52d912f 
This will clear out the buffer if there are wrong bytes along the way and only keep one packet read in at a time.

It also removed the need for member variables to store the frame information as that can be stored locally and passed onto the final processing function.
@jesserockz
Fix order
9979793
@jesserockz jesserockz merged commit 9d000e9 into esphome:dev Dec 9, 2024
25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jesserockz jesserockz jesserockz approved these changes

Assignees
No one assigned
Labels
core has-tests integration: seeed_mr60bha2 new-integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@limengdu @codecov-commenter @jesserockz @Love4yzp