Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modbus Controller] Added on_online and on_offline automation #7417

Merged
merged 10 commits into from
Nov 12, 2024
Merged

[Modbus Controller] Added on_online and on_offline automation #7417

merged 10 commits into from
Nov 12, 2024

Conversation

0x3333
Copy link
Contributor

@0x3333 0x3333 commented Sep 6, 2024 •
edited
Loading

What does this implement/fix?

Added on_online and on_offline automation to modbus_controller. In some cases, you need to configure the module when it goes back online, the offline automation is a bonus just in case.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#4231

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml
modbus_controller:
  - id: modbus_controller1
    address: 0x2
    modbus_id: mod_bus1
    on_online:
      - then:
        - logger.log: "Module Online"

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@0x3333 0x3333 requested a review from martgras as a code owner September 6, 2024 17:14
@probot-esphome
Copy link

probot-esphome bot commented Sep 6, 2024

Hey there @martgras, mind taking a look at this pull request as it has been labeled with an integration (modbus_controller) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.77%. Comparing base (4d8b5ed) to head (0d088cf).
Report is 1579 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #7417      +/-   ##
==========================================
+ Coverage   53.70%   53.77%   +0.06%     
==========================================
  Files          50       50              
  Lines        9408     9804     +396     
  Branches     1654     1354     -300     
==========================================
+ Hits         5053     5272     +219     
- Misses       4056     4206     +150     
- Partials      299      326      +27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced Sep 6, 2024
Closed
Merged
@nagyrobi
Copy link
Member

nagyrobi commented Sep 6, 2024 •
edited
Loading

Wonderful! These will be extremely useful by the time setting the entity availability will be possible!!

@0x3333 0x3333 marked this pull request as draft September 10, 2024 00:48
@0x3333 0x3333 marked this pull request as ready for review September 13, 2024 12:27
@0x3333
Copy link
Contributor Author

0x3333 commented Oct 31, 2024

Anyone in this? @martgras? Thanks

@nagyrobi nagyrobi added this to the 2024.11.0b1 milestone Oct 31, 2024
@jesserockz
Copy link
Member

jesserockz commented Nov 12, 2024 •
edited
Loading

I was about to merge, you didnt need to merge dev in again 🤣
Now it has to wait for CI to finish

@0x3333
Copy link
Contributor Author

0x3333 commented Nov 12, 2024

I was about to merge, you didnt need to merge dev in again 🤣 Now it has to wait for CI to finish

Oops...

@jesserockz jesserockz merged commit 7d75c91 into esphome:dev Nov 12, 2024
25 checks passed
@jesserockz jesserockz mentioned this pull request Nov 13, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jesserockz jesserockz jesserockz approved these changes

@martgras martgras Awaiting requested review from martgras martgras is a code owner

Assignees

@martgras martgras

Labels
has-tests integration: modbus_controller
Projects
None yet
Milestone
2024.11.0b1
Development

Successfully merging this pull request may close these issues.
5 participants
@0x3333 @codecov-commenter @nagyrobi @jesserockz @martgras