Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-quality] Apply ruff linting suggestions to core #7207

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

tomaszduda23
Copy link
Contributor

What does this implement/fix?

part of #7178

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@tomaszduda23 tomaszduda23 requested a review from a team as a code owner August 6, 2024 14:26
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.90%. Comparing base (4d8b5ed) to head (06f3beb).
Report is 1080 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #7207      +/-   ##
==========================================
+ Coverage   53.70%   53.90%   +0.20%     
==========================================
  Files          50       50              
  Lines        9408     9655     +247     
  Branches     1654     1706      +52     
==========================================
+ Hits         5053     5205     +152     
- Misses       4056     4126      +70     
- Partials      299      324      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesserockz jesserockz changed the title [code-quality] Organise core imports [code-quality] Apply ruff linting suggestions to core Aug 7, 2024
@jesserockz jesserockz merged commit 4b91ef5 into esphome:dev Aug 7, 2024
26 checks passed
zhudhjen pushed a commit to zhudhjen/esphome that referenced this pull request Aug 7, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants