Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helpers] Set default flags of ExternalRAMAllocator to ALLOW_FAILURE #7201

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

jesserockz
Copy link
Member

@jesserockz jesserockz commented Aug 6, 2024

What does this implement/fix?

All cases inside the ESPHome codebase use ALLOW_FAILURE, so this just makes sense. The flags can be cleared by specifying NONE in the constructor.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@jesserockz jesserockz requested a review from a team as a code owner August 6, 2024 04:09
@jesserockz jesserockz added this to the 2024.8.0b1 milestone Aug 6, 2024
@kbx81 kbx81 merged commit b0d9800 into dev Aug 6, 2024
26 checks passed
@kbx81 kbx81 deleted the jesserockz-2024-355 branch August 6, 2024 10:02
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants