socket: socket::set_sockaddr() for IPv4 addresses in IPv6 builds #7196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration ( |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #7196 +/- ##
==========================================
+ Coverage 53.70% 53.90% +0.19%
==========================================
Files 50 50
Lines 9408 9653 +245
Branches 1654 1706 +52
==========================================
+ Hits 5053 5203 +150
- Misses 4056 4126 +70
- Partials 299 324 +25 ☔ View full report in Codecov by Sentry. |
dwmw2
added a commit
to dwmw2/esphome_syslog
that referenced
this pull request
Aug 5, 2024
Using a Legacy IP syslog server in an IPv6-enabled build fails due to a socket::set_sockaddr() bug. Just do it ourselves for now, until it's fixed by esphome/esphome#7196
When passed a Legacy IP address as the input address string, set_sockaddr() should populate the output with a struct sockaddr_in.
jesserockz
changed the title
jesserockz
approved these changes
Aug 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing TheStaticTurtle/esphome_syslog#17 I spotted that logging to Legacy IP addresses while IPv6 is enabled doesn't work, because
socket::set_sockaddr()still populates asockaddr_sin6.When passed a Legacy IP address as the input address string, set_sockaddr() should populate the output with a struct sockaddr_in.
Types of changes
Related issue or feature (if applicable): fixes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Test Environment
Example entry for
config.yaml:# Example config.yamlChecklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: