Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust to new python pre-commit hooks #7178

Merged
merged 4 commits into from
Aug 12, 2024
Merged

adjust to new python pre-commit hooks #7178

merged 4 commits into from
Aug 12, 2024

Conversation

tomaszduda23
Copy link
Contributor

@tomaszduda23 tomaszduda23 commented Aug 2, 2024 •
edited by jesserockz
Loading

What does this implement/fix?

It applies formatting by new pre-commit hooks and lint which can be merge without the rest.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@tomaszduda23 tomaszduda23 requested a review from a team as a code owner August 2, 2024 16:34
@probot-esphome
Copy link

probot-esphome bot commented Aug 2, 2024

Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration (logger) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-esphome
Copy link

probot-esphome bot commented Aug 2, 2024

Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration (climate) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.94%. Comparing base (4d8b5ed) to head (6902720).
Report is 1091 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #7178      +/-   ##
==========================================
+ Coverage   53.70%   53.94%   +0.23%     
==========================================
  Files          50       50              
  Lines        9408     9655     +247     
  Branches     1654     1705      +51     
==========================================
+ Hits         5053     5208     +155     
- Misses       4056     4124      +68     
- Partials      299      323      +24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jesserockz
jesserockz requested changes Aug 5, 2024
View reviewed changes
Copy link
Member

@jesserockz jesserockz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you split this PR up even further so there is 1 for components, 1 for scripts (partially done in #7198), and 1 for core changes?

@esphome
Copy link

esphome bot commented Aug 5, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@esphome esphome bot marked this pull request as draft August 5, 2024 23:40
@jesserockz jesserockz mentioned this pull request Aug 5, 2024
Merged
13 tasks
This was referenced Aug 6, 2024
Merged
Merged
Merged
@tomaszduda23 tomaszduda23 marked this pull request as ready for review August 7, 2024 16:19
@esphome esphome bot requested a review from jesserockz August 7, 2024 16:19
@jesserockz jesserockz merged commit f13cf1f into esphome:dev Aug 12, 2024
26 checks passed
@jesserockz jesserockz mentioned this pull request Aug 14, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jesserockz jesserockz

Assignees
No one assigned
Labels
core small-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomaszduda23 @codecov-commenter @jesserockz