Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated version block #7177

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

tomaszduda23
Copy link
Contributor

@tomaszduda23 tomaszduda23 commented Aug 2, 2024

What does this implement/fix?

- hook id: ruff
- exit code: 1

esphome/__main__.py:976:8: UP036 Version block is outdated for minimum Python version
    |
976 |     if sys.version_info < (3, 8, 0):
    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ UP036
977 |         _LOGGER.error(
978 |             "You're running ESPHome with Python <3.8. ESPHome is no longer compatible "
    |
    = help: Remove outdated version block

It is already checked here.

requires-python = ">=3.9.0"

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@tomaszduda23 tomaszduda23 requested a review from a team as a code owner August 2, 2024 16:02
@tomaszduda23 tomaszduda23 changed the title reformat delete dead code from esphome/__main__.py Aug 2, 2024
@tomaszduda23 tomaszduda23 changed the title delete dead code from esphome/__main__.py Remove outdated version block Aug 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.89%. Comparing base (4d8b5ed) to head (0f244d3).
Report is 1064 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #7177      +/-   ##
==========================================
+ Coverage   53.70%   53.89%   +0.18%     
==========================================
  Files          50       50              
  Lines        9408     9652     +244     
  Branches     1654     1706      +52     
==========================================
+ Hits         5053     5202     +149     
- Misses       4056     4126      +70     
- Partials      299      324      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesserockz jesserockz merged commit acaec41 into esphome:dev Aug 5, 2024
26 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants