Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instead of duplicating the config, we now use const eval to validate the config #432

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Instead of duplicating the config, we now use const eval to validate the config #432

merged 1 commit into from
Feb 20, 2024

Conversation

MabezDev
Copy link
Member 

[esp-wifi]
rx_ba_win = 32
dynamic_rx_buf_num = 0

A bad config like this now panics at compile time with a nice enough error. Having all the config in one place means one won't get out of sync, which the build.rs already had.

@MabezDev MabezDev requested a review from bjoernQ February 20, 2024 16:00
@MabezDev MabezDev added the skip-changelog Skip changelog check label Feb 20, 2024
bjoernQ
bjoernQ approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@MabezDev MabezDev merged commit d200a16 into esp-rs:main Feb 20, 2024
9 checks passed
@MabezDev MabezDev deleted the const-validation branch February 20, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

Assignees
No one assigned
Labels
skip-changelog Skip changelog check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MabezDev @bjoernQ