feat: add support v flag #82
Conversation
ota-meshi
force-pushed
the
v-flag
branch
3 times, most recently
from
4a0e3dc to
9dcfdfe
Compare
|
Thank you @ota-meshi! I'll review this soon. There is one thing I noticed by looking at the AST format: I also think that the new So I think it would make sense to more clearly separate the new |
|
Good point. I think your idea makes sense. I will change the AST. |
|
I refactored this PR. Previously, a string indicating the kind was returned from some consume functions and processed. However, this was inconsistent so I refactored the consume function to return a boolean. |
|
I refactored this PR. Changed MayContainStrings to handle using result. This follows a review comment in PR in Acorn. |
|
@eslint-community/core-team @RunDevelopment |
|
Thank you for checking out this PR. I will merge this PR. |
|
🎉 This PR is included in version 4.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Hi @RunDevelopment! |
|
Joined. Thanks @ota-meshi! |
Overview
This PR adds support for v flag.
Add new AST nodes
ExpressionCharacterClassIf the character class has intersection or subtraction it will be wrapped in this node. E.g.
[a--b],[a&&b],[^a--b],[^a&&b]ClassIntersectionIt is an intersection node. E.g.
a&&bClassSubtractionIt is a subtraction node. E.g.
a--bClassStringDisjunctionIt is
\p{...}node. E.g.\q{a|b}StringAlternativeIt is
Alternativelike node inClassStringDisjunction.Change AST nodes
unicodeSetsflag. true if the regex has the v flag. It had this because negation (^) behaves differently at runtime.kind: "property")stringsflag. true if it\p{}with property of string (e.g.Basic_Emoji). It has no negation.Change API
parser.parsePatternandvalidator.validatePatternhas been changed from a booleanuFlagto an object with flags.This is because the object format is easier to use than specifying multiple flags in argument order. For backward compatibility, the old boolean value work as well.
close #80