Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add examples to prefer-await-to-then #121

Conversation

ChristianMurphy
Copy link
Contributor

What is the purpose of this pull request?

  • Documentation update

What changes did you make? (Give an overview)

Adds valid and invalid examples to prefer-await-to-then rule documentation.

Copy link
Contributor

@macklinu macklinu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@macklinu macklinu merged commit 5956eca into eslint-community:master Apr 19, 2018
@ChristianMurphy ChristianMurphy deleted the docs/prefer-await-to-then-examples branch April 19, 2018 14:50
jimthedev referenced this pull request in commitizen/cz-cli May 25, 2018
This Pull Request updates dependency [eslint-plugin-promise](https://github.com/xjamundx/eslint-plugin-promise) from `v3.7.0` to `v3.8.0`



<details>
<summary>Release Notes</summary>

### [`v3.8.0`](https://github.com/xjamundx/eslint-plugin-promise/blob/master/CHANGELOG.md#&#8203;380)
[Compare Source](eslint-community/eslint-plugin-promise@v3.7.0...v3.8.0)
* Removed `promise/avoid-new` from recommended configuration
  ([#&#8203;119](`https://github.com/xjamundx/eslint-plugin-promise/pull/119`))
* Ignored event listener callbacks in `promise/prefer-await-to-callbacks`
  ([#&#8203;117](`https://github.com/xjamundx/eslint-plugin-promise/pull/117`))
* Ignored top-level awaits in `promise/prefer-await-to-then`
  ([#&#8203;126](`https://github.com/xjamundx/eslint-plugin-promise/pull/126`))
* Added docs for `promise/no-nesting` and `promise/prefer-await-to-then`
  ([#&#8203;120](`https://github.com/xjamundx/eslint-plugin-promise/pull/120`))
  ([#&#8203;121](`https://github.com/xjamundx/eslint-plugin-promise/pull/121`))

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants