Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add no-nesting examples #120

Merged
merged 1 commit into from
Apr 19, 2018
Merged

docs: add no-nesting examples #120

merged 1 commit into from
Apr 19, 2018

Conversation

ChristianMurphy
Copy link
Contributor

What is the purpose of this pull request?

  • Documentation update

What changes did you make? (Give an overview)

Added valid and invalid examples to no-nesting rule documentation

macklinu
macklinu suggested changes Apr 19, 2018
View reviewed changes
Copy link
Contributor

@macklinu macklinu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing these docs! Conceptually these look good, but could you please double check the invalid code examples to make sure the syntax is correct? I pasted the first example into the Prettier playground and was seeing a SyntaxError. Once that's resolved, this should be good to merge. 😄

docs/rules/no-nesting.md Outdated
```js
myPromise
.then((val) => {
doSomething(val))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra parenthesis at the end

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed and formatted with prettier

docs/rules/no-nesting.md Outdated

myPromise
.then((val) => {
doSomething(val))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra parenthesis at the end

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed and formatted with prettier

docs/rules/no-nesting.md Outdated

myPromise
.catch((err) => {
doSomething(err))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra parenthesis at the end

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed and formatted with prettier

docs/rules/no-nesting.md Outdated

myPromise
.catch((err) => {
doSomething(err))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra parenthesis at the end

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed and formatted with prettier

@ChristianMurphy ChristianMurphy force-pushed the docs/no-nesting-examples branch from 8a02435 to 9918950 Compare April 19, 2018 14:54
macklinu
macklinu approved these changes Apr 19, 2018
View reviewed changes
Copy link
Contributor

@macklinu macklinu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for those changes!

@macklinu macklinu merged commit 0b231da into eslint-community:master Apr 19, 2018
@ChristianMurphy ChristianMurphy deleted the docs/no-nesting-examples branch April 19, 2018 15:54
jimthedev referenced this pull request in commitizen/cz-cli May 25, 2018
@renovate @jimthedev
chore(deps): update dependency eslint-plugin-promise to v3.8.0 (#500)
dfbd653 
This Pull Request updates dependency [eslint-plugin-promise](https://github.com/xjamundx/eslint-plugin-promise) from `v3.7.0` to `v3.8.0`



<details>
<summary>Release Notes</summary>

### [`v3.8.0`](https://github.com/xjamundx/eslint-plugin-promise/blob/master/CHANGELOG.md#&#8203;380)
[Compare Source](eslint-community/eslint-plugin-promise@v3.7.0...v3.8.0)
* Removed `promise/avoid-new` from recommended configuration
  ([#&#8203;119](`https://github.com/xjamundx/eslint-plugin-promise/pull/119`))
* Ignored event listener callbacks in `promise/prefer-await-to-callbacks`
  ([#&#8203;117](`https://github.com/xjamundx/eslint-plugin-promise/pull/117`))
* Ignored top-level awaits in `promise/prefer-await-to-then`
  ([#&#8203;126](`https://github.com/xjamundx/eslint-plugin-promise/pull/126`))
* Added docs for `promise/no-nesting` and `promise/prefer-await-to-then`
  ([#&#8203;120](`https://github.com/xjamundx/eslint-plugin-promise/pull/120`))
  ([#&#8203;121](`https://github.com/xjamundx/eslint-plugin-promise/pull/121`))

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macklinu macklinu macklinu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristianMurphy @macklinu